1706096 - Update media and Picture in Picture icons (PiP)

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P2)

Description

[Sam Foster [:sfoster] (he/him)]

We have new icons for use in Picture in Picture. Please see the procedure doc which has details on where to find the new icons, how to put together the patch and verify the result.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Since I'm pretty familiar with these, I'm going to try to de-duplicate them against their toolkit/themes/shared/media counterparts while I'm at it.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1706096 - Update media and Picture-in-Picture icons. r?sfoster!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f85c555febf
Update media and Picture-in-Picture icons. r=sfoster,desktop-theme-reviewers,harry

Comment 5

[Andreea Pavel [:apavel]]

Backed out for android build bustages and bc failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CkqOgxHbQHO9m1DpOsCxIA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6f85c555febf345fb4135ba84f93d0c6418d7369

Failure log:

• Bustage: https://treeherder.mozilla.org/logviewer?job_id=337512488&repo=autoland&lineNumber=47240
• bc failure: https://treeherder.mozilla.org/logviewer?job_id=337517371&repo=autoland&lineNumber=2333
• linting failure: https://treeherder.mozilla.org/logviewer?job_id=337514867&repo=autoland&lineNumber=908

Backout: https://hg.mozilla.org/integration/autoland/rev/5b00d3dd7af27193b42a9cdd45ec887fb84be199

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/695c41f2ed25
Update media and Picture-in-Picture icons. r=sfoster,desktop-theme-reviewers,harry

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/695c41f2ed25

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9217437 [details]
Bug 1706096 - Update media and Picture-in-Picture icons. r?sfoster!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Asset swap for new Proton icons.
• String changes made/needed: None.

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9217437 [details]
Bug 1706096 - Update media and Picture-in-Picture icons. r?sfoster!

Approved for 89 beta 6, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/d47eb0d6e4eb